Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #81
React 18 came out in March of this year.
Devs using react-bs-notifier and wishing to update to React 18 will see NPM errors about react-bs-notifier's peer dependency of react
>=16.3 <18
:As far as I can tell no changes in the library code are required for this update to work (only changes are in the docs).
The two main options I see for this update are:
react >=18
and publish a new major version of react-bs-notifierreact >=16.3
(removing<18
) since no code change was required, and publish a new minor version of react-bs-notifierI went for the first version, but I'm happy to modify the PR if option 2 is more appropriate.
Note on the updated package-lock.json file: the npm lockfile v2 format (used by npm v7) is backwards compatible to v1 lockfiles, so there shouldn't be any issues with the format change.