fix crop output padding for pixel unshuffle esrgan #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ESRGAN with pixel unshuffle mode, the input is padded and then the output is cropped to ensure the output resolution is correct, but the cropping has a small bug. When using pixel unshuffle
self.scale
is always 4 and the true scale can be recovered withself.shuffle_factor
(as is done here).The existing code does the crop assuming
self.scale
is the true scale, so when the true scale is 1 or 2, the indexes are larger than they should be and no cropping is actually done. This causes the output image to be slightly larger than it should be.In practice this doesn't affect much, downstream software like chaiNNer is unaffected since it uses
ImageModelDescriptor
which performs its own crop. But it seems like a good idea to fix anyway?