New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use neutral values in `SizeRequirements` #48

Merged

joeyballentine merged 1 commit into main from size-req-neutral-values

Nov 24, 2023

Member

RunDevelopment commented Nov 24, 2023

I didn't like that multiple_of=1 and multiple_of=None meant the same thing. Same for minimum=0 and minimum=None.

So I removed None from SizeRequirements and used neutral values instead. This will hopefully make it easier to deal with SizeRequirements.

Note: This is a breaking change.


          Use neutral values in SizeRequirements

d5913e1

joeyballentine approved these changes

View reviewed changes

joeyballentine merged commit 882d045 into main

7 checks passed

joeyballentine deleted the size-req-neutral-values branch

November 24, 2023 18:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet