auto-detect same entity for non-ligands #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
ihm
does not like when complex has identical entities, even with different names (and we for simplicity created single entity per asym_id).Here is their test: https://github.com/ihmwg/python-ihm/blob/cc4aaded6f705cd3e22de48c0ca9865b05f955da/test/test_dumper.py#L507
this commit introduces automated detection of same entity, entity is named after the first entity replica (e.g.
Entity example-peptide-copy1
for example below).Test plan
run with FASTA input: