Add ESLint on test

[Rjp-Barbara]

My contribution on Chai-http was to add tests to have an impeccable code JS and to avoid the regressions. It is important to run these tests regularly for more stable code rendering.
For this, I had to use a tool named Eslint that statically analyzes the code and verifies that it follows a certain number of rules, they are obviously configurable. ESLint is available as a NPM package, which gives us the choice between a global and local installation, but here I opted for local installation, configuration at the devDependencies level and the package.json script.
In the event of a syntax error in your code, the static analysis of this code will fail, and the error in question will be sent back to you, which you could correct from the command: npm lint: fix, and the rest mannually or by adding some exception rule.
Hope this will be helpful.

[austince]

Hi @Rjp-Barbara, thanks for the interest in chai-http! eslint is a great tool but this is a large change, and one that doesn't immediately benefit / fix anything for the consumers of this package. Changing the enforced coding style needs to be discussed with the chai-http team, so I'm going to close this for now. There has been talk of a larger update to this package - something like these eslint changes might be worth including in it. I'd suggest opening an issue with your ideas so more people can be looped in.

Your interest in contributing is great though! If you'd still like to, the good first issues are usually a good place to start, though there is not much movement there at the moment. I'm happy to let you know of any good ones in the future if you'd like to be involved.

[Rjp-Barbara]

Hello, Okay, thank you for your return and taking time for replying ! Le ven. 15 mars 2019 à 14:51, Austin Cawley-Edwards < notifications@github.com> a écrit :

…

Closed #240 <#240>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#240 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Aq1y7qTK-jjmqlhmWkXpbWXCDYcOClEKks5vW6VDgaJpZM4b2a6n> .