-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spy.on
with nullish prototype
#118
Support spy.on
with nullish prototype
#118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like travis CI is no longer working. I'll find some time to port to GitHub Actions and then get this merged, it might be a while though. |
I can have a look at writing a GitHub action for it if you want, at least for running the tests on every PR. I don't have any experience with writing an action for publishing to npm, but I'll see what I can do. This should happen for every commit on |
I'd like to move Chai packages to a model I use at work, which is that we have a build step that simply runs If you'd like to try and add those in a PR that'd be a great contribution that would be much appreciated! |
@keithamus I created another PR that sets up GitHub actions for CI and publishing (#119). The PR was created off the master branch, so it does not include the changes from this PR yet. I propose to merge #119 first, and then we can merge this one, perhaps after a rebase. |
@keithamus Is there anything that prevents releasing this on npm? I'm migrating a large codebase to Vue 3 at the moment and I'm using my own fork in {
"dependencies": {
"chai-spies": "github:sebamarynissen/chai-spies#feature/nullish-prototype",
}
} but it obviously would be nicer to be able to just use Let me know if there's anything I can do to help if needed! |
@sebamarynissen v1.1.0 has been released. Thanks! |
Fixes #117.