Issue24 eachall keys #35
Conversation
|
I regret not splitting this into three PRs, but! Here we are. |
| emptyObject = {} | ||
|
|
||
| it "should trivially all equal 1", -> | ||
| emptyObject.should.all.equal(1) |
There was a problem hiding this comment.
This seems a bit broken. I would think that an empty object should fail at .all as it has no keys.
There was a problem hiding this comment.
While I would agree...
It is currently the default behaviour, see master at test/all.coffee does:
describe "an empty array's elements", ->
emptyArray = []
it "should trivially all equal 1", ->
emptyArray.should.all.equal(1)
I considered it a breaking change to modify this behaviour.
There was a problem hiding this comment.
Okay fair enough. We'll change this in a breaking release later on then 😄
There was a problem hiding this comment.
Just as a note, all should pass if the array is empty.
If it was to fail, then it's negation would have to be true. The negation of all is 'some are not', so an empty array would have to return true if some of its elements are 'not'. However, you cannot find an element in the empty set that is 'not; so it should be false; this is definitely not be behavior you want in a some statement.
There was a problem hiding this comment.
james, were you recommending that the some statements were not behaving as expected?
There was a problem hiding this comment.
No, I'm confirming that an empty array should return true if you check to see if all of its elements are equal to 1. This is logic 101.
|
Hey @drzaal awesome work 😄. I've added some comments above, could you please address them? |
|
So, this issue I was dealing with was interoperability with the latest version of chai. Everything went tops up when I tried running chai 3.5. I've now got it testing reasonably successfully in both versions 1.4 and 3.5 |
This should resolve the issues with assertion 'keys'
Introduce the more syntactically correct 'each' decorator (synonym with all)
and operate on enumerable objects now