-
-
Notifications
You must be signed in to change notification settings - Fork 700
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
ccb2ac8
commit 514dd6c
Showing
1 changed file
with
15 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
514dd6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, this caused chaijs/chai-as-promised#18 due to the function asserters no longer having
apply
andcall
methods:514dd6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Should I add
call
andapply
to the prototype?514dd6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure. It's a bit of an edge case, but a pretty hairy one. Maybe adding most of
Function.prototype
manually would be a good idea, e.g.514dd6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created pull request #140 for this. Could you help debate the necessity of this patch there?
BTW, are you sure that the modification on line 326 was necessary?
My tests for #140 seem to indicate otherwise, but this might be a test error then.
514dd6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for #140 has been merged.