Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logically missing inverse of assert.ok() #165

Closed
Bartvds opened this issue May 21, 2013 · 0 comments · Fixed by #171
Closed

Logically missing inverse of assert.ok() #165

Bartvds opened this issue May 21, 2013 · 0 comments · Fixed by #171

Comments

@Bartvds
Copy link
Contributor

Bartvds commented May 21, 2013

There doesn't seem to be a the negation (inverse?) for the assert() style ok() assertion.

assert.notOk(value);

Of course it's possible to use a different tests, which have same effect but they break the symmetry and descriptiveness when you have things that need to be ok and others need to be not-ok.

//Test for falsy
assert.ok(!myValue);
assert.isTrue(!myValue);
assert.isFalse(!!myValue);
assert.equals(myValue, false);
//..more

It's so glaring omission, is there a reason not to have it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant