Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The online test suite does not pass #299

Closed
julienw opened this issue Nov 6, 2014 · 5 comments
Closed

The online test suite does not pass #299

julienw opened this issue Nov 6, 2014 · 5 comments

Comments

@julienw
Copy link
Contributor

julienw commented Nov 6, 2014

http://chaijs.com/api/test/ does not pass (tried in Chromium v33 and Firefox Aurora v35).

Error present in both browsers:

  • utilities > getMessage
global leaks detected: msg, negateMsg
Runner.prototype.checkGlobals@http://chaijs.com/public/js/tests/mocha.js:4229:21
Runner/<@http://chaijs.com/public/js/tests/mocha.js:4116:39
EventEmitter.prototype.emit@http://chaijs.com/public/js/tests/mocha.js:522:7
next/</<@http://chaijs.com/public/js/tests/mocha.js:4462:9
Runnable.prototype.run@http://chaijs.com/public/js/tests/mocha.js:4049:5
Runner.prototype.runTest@http://chaijs.com/public/js/tests/mocha.js:4405:5
next/<@http://chaijs.com/public/js/tests/mocha.js:4451:7
next@http://chaijs.com/public/js/tests/mocha.js:4331:1
next/<@http://chaijs.com/public/js/tests/mocha.js:4340:7
next@http://chaijs.com/public/js/tests/mocha.js:4288:1
Runner.prototype.hook/<@http://chaijs.com/public/js/tests/mocha.js:4308:5
process.nextTick</<@http://chaijs.com/public/js/tests/mocha.js:5260:28

Error present in Firefox only:

  • configuration > includeStack is true
AssertionError: should have internal stack trace in error message: expected '' to include 'assertEqual'
@keithamus
Copy link
Member

Good catch @julienw! Thanks for the issue. The actual codebase is fine, it's just the tests that are playing up - L220 & 221 just need to be prefixed with var. If you want to @julienw - you could fix the code, and make a PR and you'll end up in our wicked awesome hall of fame.

@julienw
Copy link
Contributor Author

julienw commented Nov 6, 2014

Sounds great ;) Any idea for the issue in Firefox ?

keithamus added a commit that referenced this issue Nov 6, 2014
Fix #299: the test is defining global variables
@keithamus
Copy link
Member

Seems like the firefox issue is a regression of sorts, as Firefox <=27 passes, but Firefox >=33 doesn't. I'm going to try and localise the issue further - but if you could please make a separate issue for this @julienw, it would be appreciated 😄

@keithamus
Copy link
Member

@julienw Firefox 28 and above seems to have the error.

@moimikey
Copy link

moimikey commented Nov 7, 2014

got the same for chrome 38.0.2125.111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants