-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The online test suite does not pass #299
Comments
Good catch @julienw! Thanks for the issue. The actual codebase is fine, it's just the tests that are playing up - L220 & 221 just need to be prefixed with var. If you want to @julienw - you could fix the code, and make a PR and you'll end up in our wicked awesome hall of fame. |
Sounds great ;) Any idea for the issue in Firefox ? |
Fix #299: the test is defining global variables
Seems like the firefox issue is a regression of sorts, as Firefox <=27 passes, but Firefox >=33 doesn't. I'm going to try and localise the issue further - but if you could please make a separate issue for this @julienw, it would be appreciated 😄 |
@julienw Firefox 28 and above seems to have the error. |
got the same for chrome 38.0.2125.111 |
http://chaijs.com/api/test/ does not pass (tried in Chromium v33 and Firefox Aurora v35).
Error present in both browsers:
Error present in Firefox only:
The text was updated successfully, but these errors were encountered: