-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should.be.true syntax that passes eslint #445
Comments
Hey @jwynveen thanks for the issue. We dropped that style as of #371 also mentions this - so this issue is a duplicate of that. Have a look at #371 (comment) for some full context and history. Solutions:
I've been thinking up a solution for this - which one day may be implemented, but don't hold your breath. |
which would be the equivalent of |
@luislobo you probably should test what it is rather than what it isn't, so for example |
I am trying to update from 1.10.0 to the current version, but there seem to be breaking changes. We are using
object.should.be.true()
throughout our tests, but it seems to no longer exists as a function. I see in the release notes that there is information about it being a property, although the function is supposed to still exist for linting purposes. That note was on 1.10.0. It seems the function no longer exists and there are no further release notes about it. I can easily switch all of them, but then they don't pass my eslint rules. How is that type of assertion supposed to be used in a way that passes eslint?The text was updated successfully, but these errors were encountered: