Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing assert parameters in documentation #1023

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

Hpauric
Copy link
Contributor

@Hpauric Hpauric commented Aug 9, 2017

Fix for issue #1017

Optional message parameter added to documentation for:

  • .ifError
  • .isExtensible
  • .isNotExtensible
  • .isFrozen
  • .isNotFrozen
  • .isEmpty
  • .isNotEmpty

@Hpauric Hpauric requested a review from a team as a code owner August 9, 2017 10:05
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. @chaijs/chai anyone else want to approve + merge this?

@keithamus
Copy link
Member

Just noticed this PR edited chai.js - so we'll need to rework this to the right places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants