-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added testling-ci integration. Fixes #124 #149
Closed
Closed
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
26132ab
Added files for testling integration
twolfson 144a759
Pointed to wrong bootstrap.js >_<
twolfson d753a4a
Something seemed to get lost in last build
twolfson 377aea5
Patch for "expect satisfy" failing in IE10
twolfson 4903e6c
Removing failing browsers from testling-ci
twolfson 8cf3d82
Testling is failing to kick off with last change, trying manually del…
twolfson 554364c
Moving back to see testling is the problem o_o
twolfson dc5f6c9
Reverting IE10 test patch for single purpose PRs
twolfson c1534ef
Testing testling-ci reboot
twolfson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
err = function (fn, msg) { | ||
try { | ||
fn(); | ||
throw new chai.AssertionError({ message: 'Expected an error' }); | ||
} catch (err) { | ||
if ('string' === typeof msg) { | ||
chai.expect(err.message).to.equal(msg); | ||
} else { | ||
chai.expect(err.message).to.match(msg); | ||
} | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a patch so that IE10 would pass its test. It turns out named functions in IE10 look like "[Function: matcher ]" vs normal browsers with "[Function: matcher]".
This can be seen on https://ci.testling.com/twolfson/chai under d753a4a -> IE10 ->
not ok 80 expect satisfy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include in a different PR? Would like to get it included asap (ci stuff might take longer) and want to make sure you get credit for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing. I was hesitant on tossing this in here but it seemed like such a small change. One updated PR coming up!