-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support big int in approximently #1606
Merged
koddsson
merged 14 commits into
chaijs:main
from
koddsson:support-big-int-in-approximently
Oct 9, 2024
Merged
Support big int in approximently #1606
koddsson
merged 14 commits into
chaijs:main
from
koddsson:support-big-int-in-approximently
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
force-pushed
the
support-big-int-in-approximently
branch
from
October 6, 2024 17:20
013e6a0
to
3587410
Compare
43081j
reviewed
Oct 8, 2024
43081j
reviewed
Oct 9, 2024
43081j
reviewed
Oct 9, 2024
43081j
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new assertion property
numeric
which checks if given variable is of typeNumber
orBigInt
. Then used that new assertion to replace ais.a('number')
check in thecloseTo
/approximately
assertion.Also replaced a
Math.abs
function call which doesn't supportBigInt
which all adds up to supportingBigInt
incloseTo
/approximately
.TODO
numeric
assertion.Follow up
Fixes #1465