Build with more AMD compliant wrapper #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuild chai.js using an updated component that fixes an AMD wrapper bug.
|
Thank you for opening the issue! Could you please share the component fork with us, and also could you please link the PR so we can keep track of it? We are always more than happy to improve the library in order to be more accessible for everyone. Thanks! |
|
Sure, the PR is componentjs/component#459. The fork is at jason0x43/component. |
|
The referenced PR has been merged. |
|
Upstream has fixed this issue, so you just need to update to component 0.19.4+ and build and release. Thanks! |
|
+1 on getting this in! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild chai.js using an updated component that fixes an AMD wrapper
bug. There's a PR for the fix to component.