fixing #239 (without changing chai.js)

[leider]

• hope this is better

[logicalparadox]

Much better! Unfortunately, not quite ready yet. I think you will have an issue if no match is found. The best way is to add assertions that fail using err(function() { .... For each assertion you add in test/expect.js you should also have an assertion that fails wrapped with that pattern.

PS: No need to open a new PR this time, you can just append to this one.

[leider]

done. :) Thx for the eagle eyes

[leider]

done again

[leider]

Hi, did you forget about this one? :)

[adambiggs]

Any timeline on merging this? #239 is the only thing preventing me from upgrading :(

[lo1tuma]

@adambiggs it is already merged. I don’t know why #239 is still open and why there was no patched version released.

[adambiggs]

@lo1tuma oops, I meant to ask about publishing this to NPM... 😕

[lo1tuma]

@logicalparadox can you release a patched version on npm?

[logicalparadox]

Released in 1.9.1. View release notes.

[lo1tuma]

Thanks! 🍻