Fix #265 #361
Merged
Fix #265 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregglind
commented
Feb 7, 2015
gregglind
commented
- We didn't throw on 'too many args' before. Should we now? If so, what?
- (Do docs run as tests, if so how?)
- (Tests inbound. WIP mostly to claim the bug :) )
gregglind
force-pushed
the
b265-keys-object
branch
from
4db3314
to
0baa6f1
Compare
|
See #265 |
| } | ||
| } else { | ||
| keys = Array.prototype.slice.call(arguments); | ||
| } |
There was a problem hiding this comment.
It might read clearer to use the _.type function:
if (_.type(keys) === 'object') {
keys = Object.keys(keys);
} else if (arguments.length > 1) {
keys = Array.prototype.slice.call(arguments);
}
gregglind
force-pushed
the
b265-keys-object
branch
from
0baa6f1
to
2b46e95
Compare
|
Went to switch based, using |
| ? keys | ||
| : Array.prototype.slice.call(arguments); | ||
| , ok = true | ||
| , mixedArgsMsg = "keys: if first argument is instanceof Array|Object, must be only argument." |
There was a problem hiding this comment.
I think this error needs rephrasing, maybe to something like 'keys must be given single argument of Array, Object, or multiple String arguments'
There was a problem hiding this comment.
Rephased to:
var mixedArgsMsg = 'keys must be given single argument of Array|Object|String, or multiple String arguments'
I think that is accurate. I do wonder if we should emphasize the 'multiple arguments' part, because that is what triggered the error.
- `.keys(object)n => .keys(Object.keys(Object)` - added exceptions for 'if first arg is non-string, then it must be only arg. => `.keys(Array|Object, ...)` Warning: `Object.keys` must exist on systems to use this functionality.
gregglind
force-pushed
the
b265-keys-object
branch
from
2b46e95
to
4f40b37
Compare
|
I'd say this is good to go. Let's get it merged in. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.