Cause deep.have.same.members() to print a diff. #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
added a commit
that referenced
this pull request
Oct 2, 2015
Cause deep.have.same.members() to print a diff.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, when the above assertion fails, one gets the rather unhelpful error message "expected [ Array(n) ] to have the same members as [ Array(m) ]". If the arrays are the same size, but some value in them is different, this isn't very helpful. It usually ends with me printing out the two arrays to the console and attempting to do a diff myself anyway.
By simply passing
showDiff = trueto assert() , it indicates that the arrays should be diffed when the error is printed. This functionality is tested in mocha 2.2.5 for both cases where either array is missing a value in the other and where the value differs between the arrays.