Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @keithamus, according to what we've been talking on #515, this is the Makefile I was using when making my changes. I avoided using
lib/**
as you said, instead I added theclean-browser
task as a dependency of every browser's tests.I've also edited
CONTRIBUTING.md
with clearer instructions according to the new Makefile.I also have a doubt: are you guys planning on using Gulp? Personally, I think it would be more friendly both for different platforms (Windows doesn't have Make available, for example) and for JS programmers (which are used to this kind of task automation).