Add ordered flag for members assertions #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , subset | ||
| , obj | ||
| ); | ||
| lengthCheck = true; |
There was a problem hiding this comment.
Nice work using lengthCheck at this assertion. The code looks more clean 👍
|
Awesome work, as always. I went through it all and I couldn't even find a single typo. |
| return subset.every(function(elem) { | ||
| function isSubsetOf(subset, superset, cmp, ordered) { | ||
| return subset.every(function(elem, idx) { | ||
| if (ordered) return cmp ? cmp(elem, superset[idx]) : elem === superset[idx]; |
There was a problem hiding this comment.
I'll leave this here just to make other reviewer's job easier.
This line is related to the behaviour we talked about at this post.
|
@lucasfcosta Thank you for reviewing :D |
|
Great work @meeber 😄. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.orderedfunctionality on every interface along with testsnotassertions for existing member assertions onassertinterface