fix: make negated .keys consider size of sets
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When neither the `contains` nor `any` flags are set, the `.keys` assertion implicitly means `.all.keys` and thus requires the target and given sets to be the same size. Therefore, `not.keys` implicitly means `.not.all.keys`, and should thus pass when the target and given sets aren't the same size, even if the target set is a superset of the given set. This commit enables this behavior.
|
LGTM! Seems more straightforward this way. Good job! |
lucasfcosta
approved these changes
Feb 2, 2017
|
This is a small one. Pinging @keithamus @vieiralucas @shvaikalesh |
|
Okay, happy enough with this given the context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When neither the
containsnoranyflags are set, the.keysassertion implicitly means
.all.keysand thus requires the targetand given sets to be the same size. Therefore,
not.keysimplicitlymeans
.not.all.keys, and should thus pass when the target and givensets aren't the same size, even if the target set is a superset of the
given set. This commit enables this behavior.
Fixes #919