Update browserify to the latest version 🚀 #951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
|
nodejs.org appears to be having network issues, which is causing the nvm install in Travis to fail, which is causing Travis to default to using the preinstalled Node v0.10.x when running tests, which is causing our Node-based test suite to fail because we no longer support Node v0.10.x after a recent change we made regarding Buffers in deep-eql. But, even if the above wasn't true, per #932 (comment) the sauce-based IE10 test suite would've ended up failing anyway due to a separate Buffer-related incompatibility issue that's introduced with one of Browserify v14's dependencies that make it incompatible with IE 10, which we do still support. So in conclusion: Closing this :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 14.2.0 of browserify just got published.
The version 14.2.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of browserify.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 13 commits .
18e1d6514.2.00e1a7a0add cli support for --transform-key to support mode's like production/staging/etc..a5aa660Merge pull request #1701 from wogsland/doc-fixae281bcFixed documentation formatting that was bugging mefe8c57basync test for node 706a47d114.1.067ea8b1Merge branch 'patch-1' of https://github.com/natevw/node-browserify691239d14.0.060cd894changelog: 14.0.0d7ea3ddMerge pull request #1678 from substack/buffer-54f5d93btest: pass Uint8Array into vm context for buffer v5ae33350Update 'buffer' to v5.xea6c299Write to temp outfile until success, fixes #899See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴