Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 4.0.0-canary.2 #957

Merged
merged 2 commits into from
Apr 12, 2017

Conversation

keithamus
Copy link
Member

@keithamus keithamus commented Apr 11, 2017

@chaijs/chai

Also we've broken 4000 stargazers, so 🎉 🍾

Copy link
Member

@vieiralucas vieiralucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
🚀 🚀

Congratulations to @chaijs/chai for the 4000 stargazers
🎉 🍾 🎉

@meeber
Copy link
Contributor

meeber commented Apr 12, 2017

LGTM, but I recall we had an issue last time when merging and tagging a new canary release that caused it to automatically be marked as latest in npm. Do we know what caused that? Does it have to do with this:

chai/.travis.yml

Lines 22 to 31 in 526f885

deploy:
provider: npm
email:
secure: "M9J56tqJwOxn6D3PSh8BNGac/8XjTCRGCFexN5QFl7Ha9AKnyQTy1ZAaJonMGoClBhh37Dy/89wVWmqg4NPckrD5Ej7NvwhTjVfEHusllaCROqVu5m7ijS3WKlIxM/xtBzU7SqRY41JxloP+CLKxRiKRWQJDvgwUZW7OHdmAkAY="
api_key:
secure: ihzLWemQDFmsF4iQ3sS5/Wt0GQy6v15WgsxYfocpLuYWjxaAWgB4vQ3gUar8UpnE7lEFtNUOTIkPob0MSgNrFjoH2PB1sh5cW/acDE7kF7Z7hVxr8zGWkgiWXeNd08lz1mruizK1L/I0o2k/7o7zEDzShpsYSwgWfekzbJxLtC8=
on:
tags: true
repo: chaijs/chai
all_branches: true

@keithamus
Copy link
Member Author

keithamus commented Apr 12, 2017

@meeber yes I'm aware of the issues. Basically when we tag a commit, travis will automatically npm pub. It's a bit low-key but we can cancel the build before that happens, and manually publish - or alternatively let it publish 4.0.0-canary.2 to latest and then quickly run npm dist-tag set chai@3.4.5 latest and hope no one notices 😆

We also could temporarily disable travis' publishing for now.

@keithamus
Copy link
Member Author

So... I've commented out the deploy step. Travis wont deploy now. Once this is merged it'll need manually publishing as npm pub --tag canary. I will do this on my local machine once merged.

@meeber
Copy link
Contributor

meeber commented Apr 12, 2017

@keithamus Looks clear to proceed when you're ready!

@keithamus keithamus merged commit 850bd7e into chaijs:master Apr 12, 2017
@keithamus keithamus deleted the release/4.0.0-canary.2 branch April 12, 2017 22:12
@lucasfcosta
Copy link
Member

Awesome job, everyone!
I can't wait to get 4.0.0 out!
You rock! 🍾

@keithamus
Copy link
Member Author

FYI, just published this:

npm show chai

{ name: 'chai',
  description: 'BDD/TDD assertion library for node.js and the browser. Test framework agnostic.',
  'dist-tags': { latest: '3.5.0', canary: '4.0.0-canary.2' },
  --->8---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants