-
-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 4.0.0-canary.2 #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 🚀
Congratulations to @chaijs/chai for the 4000 stargazers
🎉 🍾 🎉
LGTM, but I recall we had an issue last time when merging and tagging a new canary release that caused it to automatically be marked as latest in npm. Do we know what caused that? Does it have to do with this: Lines 22 to 31 in 526f885
|
@meeber yes I'm aware of the issues. Basically when we tag a commit, travis will automatically We also could temporarily disable travis' publishing for now. |
So... I've commented out the deploy step. Travis wont deploy now. Once this is merged it'll need manually publishing as |
@keithamus Looks clear to proceed when you're ready! |
Awesome job, everyone! |
FYI, just published this: npm show chai
{ name: 'chai',
description: 'BDD/TDD assertion library for node.js and the browser. Test framework agnostic.',
'dist-tags': { latest: '3.5.0', canary: '4.0.0-canary.2' },
--->8--- |
@chaijs/chai
Also we've broken 4000 stargazers, so 🎉 🍾