Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError: Cannot convert a Symbol value to a string #89

Merged
merged 3 commits into from
Sep 14, 2022
Merged

fix: TypeError: Cannot convert a Symbol value to a string #89

merged 3 commits into from
Sep 14, 2022

Conversation

erezarnon
Copy link
Contributor

No description provided.

@erezarnon
Copy link
Contributor Author

@keithamus quick ping, fixing an exception

@keithamus
Copy link
Member

Some failing lint errors, if you'd kindly address those I'll merge

@erezarnon
Copy link
Contributor Author

Some failing lint errors, if you'd kindly address those I'll merge

Done!

@keithamus keithamus merged commit 5eeaeb4 into chaijs:main Sep 14, 2022
@erezarnon
Copy link
Contributor Author

@keithamus Thank you! Is it worth tagging a release?

@keithamus
Copy link
Member

Done!

snewcomer added a commit to snewcomer/deep-eql that referenced this pull request Nov 5, 2022
@snewcomer
revert: chaijs#89
52f705f
@snewcomer snewcomer mentioned this pull request Nov 5, 2022
Merged
keithamus pushed a commit that referenced this pull request Nov 5, 2022
@snewcomer
fix: multiple symbols and sort fails - Cannot convert a Symbol value …
a311421 
…to a string (#83)

* fix: multiple symbols and sort fails - Cannot convert a Symbol value to a string

* revert: #89

* refactor: no if check
@renovate renovate bot mentioned this pull request Apr 10, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezarnon @keithamus