Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: loupe@2 #14
feat: loupe@2 #14
Changes from 1 commit
e11b077
9c3c977
0865041
50deda1
a219179
223903b
81da557
39cb9c0
674c4a8
422eec6
5982647
1c85d29
9b68b95
0d94a2a
00322c4
fd4f089
0d6b6fd
6dd1f06
9569a04
01bbc62
f0a30ab
f1dbf19
a851c2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't someone set a custom
inspect
for those base values? IMO it's not an exotic use case and therefore the check forcustomInspect
could come first. Not sure I'm missing something here though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is to keep the base types protected. We don't want users to override base types to provide their own inspection; the custom inspection is really meant as a fallback for users who want to provide inspection for their own objects, not for builtins.
Essentially, I want to discourage the use of overriding for builtins because I don't think it will add value to this lib. Happy to hear otherwise though.