Add pointer to chai-samsam for Sinon.assert.match
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinon has one outlier assertion, `Sinon.assert.match`, that is not a spy method, and doesn't make sense to implement as part of this library, so instead add a pointer to `chai-samsam`, which implements a compatible assertion separately.
solaris007
referenced
this pull request
in adobe/spacecat-audit-post-processor
Aug 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [junit-report-builder](https://togithub.com/davidparsson/junit-report-builder) | [`3.2.1` -> `5.0.0`](https://renovatebot.com/diffs/npm/junit-report-builder/3.2.1/5.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sinon-chai](https://togithub.com/chaijs/sinon-chai) | [`3.7.0` -> `4.0.0`](https://renovatebot.com/diffs/npm/sinon-chai/3.7.0/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>davidparsson/junit-report-builder (junit-report-builder)</summary> ### [`v5.0.0`](https://togithub.com/davidparsson/junit-report-builder/compare/4.0.1...5.0.0) [Compare Source](https://togithub.com/davidparsson/junit-report-builder/compare/4.0.1...5.0.0) ### [`v4.0.1`](https://togithub.com/davidparsson/junit-report-builder/compare/4.0.0...4.0.1) [Compare Source](https://togithub.com/davidparsson/junit-report-builder/compare/4.0.0...4.0.1) ### [`v4.0.0`](https://togithub.com/davidparsson/junit-report-builder/compare/3.2.1...4.0.0) [Compare Source](https://togithub.com/davidparsson/junit-report-builder/compare/3.2.1...4.0.0) </details> <details> <summary>chaijs/sinon-chai (sinon-chai)</summary> ### [`v4.0.0`](https://togithub.com/chaijs/sinon-chai/releases/tag/4.0.0) [Compare Source](https://togithub.com/chaijs/sinon-chai/compare/3.7.0...4.0.0) #### What's Changed - Add pointer to `chai-samsam` for Sinon.assert.match by [@​cincodenada](https://togithub.com/cincodenada) in [https://github.com/chaijs/sinon-chai/pull/156](https://togithub.com/chaijs/sinon-chai/pull/156) - Add brief note about `.always` prefix to README by [@​cincodenada](https://togithub.com/cincodenada) in [https://github.com/chaijs/sinon-chai/pull/153](https://togithub.com/chaijs/sinon-chai/pull/153) - Add support for Chai version 5 by [@​robinbisping](https://togithub.com/robinbisping) in [https://github.com/chaijs/sinon-chai/pull/161](https://togithub.com/chaijs/sinon-chai/pull/161) - Set up CI by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/sinon-chai/pull/163](https://togithub.com/chaijs/sinon-chai/pull/163) - Create npm-publish.yml by [@​koddsson](https://togithub.com/koddsson) in [https://github.com/chaijs/sinon-chai/pull/164](https://togithub.com/chaijs/sinon-chai/pull/164) - chore: upgrade deps and use c8/prettier by [@​43081j](https://togithub.com/43081j) in [https://github.com/chaijs/sinon-chai/pull/166](https://togithub.com/chaijs/sinon-chai/pull/166) #### New Contributors - [@​cincodenada](https://togithub.com/cincodenada) made their first contribution in [https://github.com/chaijs/sinon-chai/pull/156](https://togithub.com/chaijs/sinon-chai/pull/156) - [@​robinbisping](https://togithub.com/robinbisping) made their first contribution in [https://github.com/chaijs/sinon-chai/pull/161](https://togithub.com/chaijs/sinon-chai/pull/161) - [@​koddsson](https://togithub.com/koddsson) made their first contribution in [https://github.com/chaijs/sinon-chai/pull/163](https://togithub.com/chaijs/sinon-chai/pull/163) - [@​43081j](https://togithub.com/43081j) made their first contribution in [https://github.com/chaijs/sinon-chai/pull/166](https://togithub.com/chaijs/sinon-chai/pull/166) **Full Changelog**: chaijs/sinon-chai@3.7.0...4.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/adobe/spacecat-audit-post-processor). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominique Jäggi <djaeggi@adobe.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinon has one outlier assertion,
Sinon.assert.match, that is not a spy method, and doesn't make sense to implement as part of this library, so instead add a pointer tochai-samsam, which implements a compatible assertion separately.This addresses #92, which at the time was closed because I think
Sinon.assert.matchdidn't exist yet.