Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop caching existence of window #134

Merged
merged 1 commit into from
Jan 19, 2018
Merged

fix: stop caching existence of window #134

merged 1 commit into from
Jan 19, 2018

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Jan 18, 2018

Caching the existence of window introduces problems in quasi-browser
environments where it's not uncommon to unset window before some tests.

Fixes #133

Caching the existence of `window` introduces problems in quasi-browser
environments where it's not uncommon to unset `window` before some tests.
@meeber meeber requested a review from a team as a code owner January 18, 2018 22:13
@codecov
Copy link

codecov bot commented Jan 18, 2018

Codecov Report

Merging #134 into master will decrease coverage by 2.88%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   85.71%   82.82%   -2.89%     
==========================================
  Files           1        1              
  Lines         105       99       -6     
==========================================
- Hits           90       82       -8     
- Misses         15       17       +2
Impacted Files Coverage Δ
index.js 82.82% <90%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd38626...223ffec. Read the comment docs.

@astorije astorije merged commit 992ebe7 into chaijs:master Jan 19, 2018
@keithamus
Copy link
Member

Thanks for going through the motions with this @meeber. The whole window thing is a PITA, so thanks for perserveering!

@meeber meeber deleted the fix-window-caching branch January 19, 2018 12:31
@meeber
Copy link
Contributor Author

meeber commented Jan 19, 2018

@keithamus Happy to do it. And thanks to you and @astorije for helping out with all of these PR reviews.

@astorije
Copy link
Member

No worries! I'm not helping much, you're doing the real work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants