Do not call getter when checking for Symbol.toStringTag in obj #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. My fault: sometimes I am a bit hesitant to check "request changes" on not so important stuff. |
shvaikalesh
approved these changes
Apr 20, 2017
vieiralucas
approved these changes
Apr 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that I made the huge mistake of merging #95 before seeing @shvaikalesh's comment about triggering the
Symbol.toStringTaggetter inobjI think it was better to just fix this in a separate PR than reverting stuff and putting it back in.I'm really sorry for this 😓