-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downgrade runner to ubuntu 22.04 #4
Conversation
📝 WalkthroughWalkthroughThis pull request updates the CI workflow configurations to use Ubuntu 22.04 instead of the latest Ubuntu version. Both the CI and release workflows now specify the new operating system for the Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Runner
participant Job as BuildBinary Job
CI->>Job: Trigger binary build job
Job->>Job: Create version-specific directory (camino-conduit-<tag>)
Job->>Job: Copy binary into directory
Job->>Job: Compress directory into tarball
Job-->>CI: Return packaged artifact
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
43-45
: Organize Binary Packaging into Version-Specific Directory
The commands create a directory namedcamino-conduit-${{ github.event.release.tag_name }}
within the build directory, copy the binary into it, and then package it. This restructuring meets the objective of organizing the output binary effectively.Consider adding a check to verify that
./build/camino-conduit
exists before copying, to prevent potential errors if the build step fails. Additionally, wrapping file paths in quotes (e.g.,"./build/camino-conduit-${{ github.event.release.tag_name }}"
) could help avoid issues with unexpected spaces in the version tag, though such cases may be rare.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci.yml
(2 hunks).github/workflows/release.yml
(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/ci.yml
🔇 Additional comments (2)
.github/workflows/release.yml (2)
13-13
: Update Runner for Build Docker Job
Theruns-on: ubuntu-22.04
setting is correctly applied, ensuring that the Docker build job runs in the desired environment as per the PR objectives.
35-35
: Update Runner for Build Binary Job
The change fromubuntu-latest
toubuntu-22.04
guarantees consistent build conditions for the binary job, aligning perfectly with the specified PR changes.
Summary by CodeRabbit