make param optional in client

chain4travel · Mar 21, 2022 · 8670c84 · 8670c84
1 parent ce13a19
commit 8670c84
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/client/client.go b/client/client.go
@@ -30,7 +30,7 @@ type Config struct {
 
 type Client interface {
 	Ping(ctx context.Context) (*rpcpb.PingResponse, error)
-	Start(ctx context.Context, execPath string, numNodes uint32, opts ...OpOption) (*rpcpb.StartResponse, error)
+	Start(ctx context.Context, execPath string, opts ...OpOption) (*rpcpb.StartResponse, error)
 	Health(ctx context.Context) (*rpcpb.HealthResponse, error)
 	URIs(ctx context.Context) ([]string, error)
 	Status(ctx context.Context) (*rpcpb.StatusResponse, error)
@@ -92,14 +92,14 @@ func (c *client) Ping(ctx context.Context) (*rpcpb.PingResponse, error) {
 	return c.pingc.Ping(ctx, &rpcpb.PingRequest{})
 }
 
-func (c *client) Start(ctx context.Context, execPath string, numNodes uint32, opts ...OpOption) (*rpcpb.StartResponse, error) {
-	ret := &Op{}
+func (c *client) Start(ctx context.Context, execPath string, opts ...OpOption) (*rpcpb.StartResponse, error) {
+	ret := &Op{numNodes: local.defaultNumNodes}
 	ret.applyOpts(opts)
 
 	zap.L().Info("start")
 	return c.controlc.Start(ctx, &rpcpb.StartRequest{
 		ExecPath:           execPath,
-		NumNodes:           numNodes,
+		NumNodes:           &ret.numNodes,
 		WhitelistedSubnets: &ret.whitelistedSubnets,
 		LogLevel:           &ret.logLevel,
 	})
@@ -203,6 +203,7 @@ func (c *client) Close() error {
 }
 
 type Op struct {
+	numNodes           uint32
 	whitelistedSubnets string
 	logLevel           string
 }
@@ -215,6 +216,12 @@ func (op *Op) applyOpts(opts []OpOption) {
 	}
 }
 
+func WithNumNodes(numNodes uint32) OpOption {
+	return func(op *Op) {
+		op.numNodes = numNodes
+	}
+}
+
 func WithWhitelistedSubnets(whitelistedSubnets string) OpOption {
 	return func(op *Op) {
 		op.whitelistedSubnets = whitelistedSubnets