New extended genesis plus necessary adjustments for supporting camino #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikos
force-pushed
the
camino_genesis_support
branch
from
f7d9c89 to
5440d27
Compare
c4t-ag
requested changes
Feb 7, 2023
local/network.go
Outdated
| camino["verifyNodeSignature"] = true | ||
| camino["lockModeBondDeposit"] = true | ||
| } else { | ||
| startTime := time.Now().Unix() |
There was a problem hiding this comment.
We want this, too for camino.
It's a cool thing, and we recently changed that offerID's do not chnage anymore if StartTime changes
knikos
force-pushed
the
camino_genesis_support
branch
from
39d6755 to
1d12c53
Compare
knikos
force-pushed
the
camino_genesis_support
branch
from
1d12c53 to
5d6e9bb
Compare
c4t-ag
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR contains changes which are necessary for starting a camino network. Till now the network runner was "compatible" only with avax networks. Supporting the camino network is necessary among others for e2e tests performed by the caminojs.
How this works
To enable the above mentioned functioncality, the following changes are necessary:
How this was tested
By starting the network, querying and verifying the network's configuration and running caminojs e2e tests against it.