Removed submodules, updated dependencies, msig-alias removal indexing #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
evlekht
commented
Aug 19, 2024
•
evlekht
commented
- Replaced caminogo and caminoethvm submodule dependencies with normal go mod references.
- Updated caminoethvm and caminogo to latest dev.
- Updated golang from 1.18 to 1.19 in Dockerfile and ci.yml.
- Updated golangci lint.
- Added msig-alias removal indexing.
evlekht
force-pushed
the
evlekht/msig-alias-removal
branch
from
9f985c7 to
26adb8f
Compare
evlekht
force-pushed
the
evlekht/msig-alias-removal
branch
from
811f0db to
00ae357
Compare
mo-c4t
reviewed
Aug 20, 2024
| - name: Submodules | ||
| run: git submodule update --init --recursive | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 |
There was a problem hiding this comment.
why did you remove this action? it installs golangci-lint.
There was a problem hiding this comment.
Because its also run from sh script. And I'd prefer to run it in sh script, cause we can add other linters in that script (like in caminogo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.