Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move proof verification logic to the sidecar #24

Closed
thedevbirb opened this issue May 14, 2024 · 2 comments
Closed

Move proof verification logic to the sidecar #24

thedevbirb opened this issue May 14, 2024 · 2 comments
Labels
C: bolt-sidecar Component: bolt-sidecar C: mev-boost Component: mev-boost T: chore Type: Chore

Comments

@thedevbirb
Copy link
Contributor

thedevbirb commented May 14, 2024

When the builder submits a bid with proofs of transaction inclusion, the relay propagates them and they're verified inside our mev-boost fork. However, since the sidecar is the entrypoint from the builder api and a proxy for mev-boost it makes sense to move proof verification there, and keep the mev-boost fork as light as possible.

@thedevbirb thedevbirb added C: mev-boost Component: mev-boost C: bolt-sidecar Component: bolt-sidecar T: chore Type: Chore labels May 14, 2024
@thedevbirb thedevbirb changed the title chore(mev-boost): Move proof verification logic to the sidecar Move proof verification logic to the sidecar May 14, 2024
@mempirate mempirate added this to the v0.1 milestone May 22, 2024
@mempirate
Copy link
Contributor

Will leave the issue open but remove it from milestone as we will not do this for the first version. Otherwise bolt-boost cannot really be used as a standalone builder constraint mechanism since it doesn't even verify the proofs.

@merklefruit
Copy link
Collaborator

The reason we verify proofs in mev-boost is because we might otherwise pick a best_bid that has invalid proofs and send it to the sidecar. Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: bolt-sidecar Component: bolt-sidecar C: mev-boost Component: mev-boost T: chore Type: Chore
Projects
None yet
Development

No branches or pull requests

3 participants