feat(sidecar): build valid fallback payload #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
added
C: bolt-sidecar
mempirate
reviewed
Jun 18, 2024
| @@ -113,6 +113,8 @@ impl<T: ConstraintsApi, P: PayloadFetcher + Send + Sync> BuilderProxyServer<T, P | |||
| { | |||
| Ok(Ok(header)) => { | |||
| tracing::debug!(elapsed = ?start.elapsed(), "Returning signed builder bid: {:?}", header); | |||
| // TODO: verify proofs here. If they are invalid, we should fall back to locally built block | |||
There was a problem hiding this comment.
We don't need to verify proofs again imo. We can assume mev-boost & relay have already done this. If mev-boost verification fails it will just return no bid
There was a problem hiding this comment.
Makes sense, just thought it would be low cost, plus as a reminder for #24 which is still open
merklefruit
force-pushed
the
feat/sidecar/builder-api
branch
from
1c7f647
to
c97e519
Compare
merklefruit
force-pushed
the
feat/create-fallback-block
branch
from
dbe07b2
to
9983438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.