-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import website from aestus upstream, solve conflicts #25
Conversation
Co-authored-by: DigiDr <DigiDr@users.noreply.github.com> Co-authored-by: austonst <austonst@users.noreply.github.com>
187e267
to
f995522
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I'd re-check what are the minimum requirements to serve the website and remove everything unnecessary and move them to separate PRs if needed.
I tried to minimize the diffs, now testing this version on our devnet. Edit: seems OK. This branch has been pushed as image |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
website
crate from upstream: https://github.com/aestus-relay/helix/tree/constraints-api-v0/crates/website/srcjust fmt fmt-check clippy
with the pinned toolchain.0.0.0.0