forked from Uniswap/interface
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helder demo #1
Draft
thedevbirb
wants to merge
15
commits into
main
Choose a base branch
from
helder-demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Helder demo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: nicolas <merklefruit@users.noreply.github.com>
Co-authored-by: nicolas <merklefruit@users.noreply.github.com>
Co-authored-by: thedevbirb <lorenzo@chainbound.io>
Co-authored-by: thedevbirb <lorenzo@chainbound.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the interface flow to show an example of inclusion preconfirmation on a real app leveraging the Bolt RPC and proposers running the Bolt sidecar on the Helder testnet.
Tasklist
wallet_sendTransaction
JSON-RPC method to just test the flow and the integration with the Bolt RPC -> Lead to some tiny fixes in the Bolt RPC + we know have https://bolt.chainbound.io/rpc!eth_getBalance
with Bolt RPC. Note: useuseAsyncMemo
or similar constructs to avoid async function coloring. The usual Uniswap flow is very specific and lastly requires a custom endpoint that doesn't support every chain. We can't use that endpoint and we want to addasync/await
in every filewallet_sendTransaction
towallet_signMessage
(if available, oreth_sign
as a non-optimal alternative) +eth_sendRawTransaction
to Bolt RPC, to bypass Metamask for that and having more flexibility. Note: the currentethers.js
version (v5.7.2
) doesn't supportwallet_signTransaction
unfortunately.send
page.Notes
Sending transactions via wallets
wallet_signTransaction
due to difficult nonce management. See Sign transaction without broadcast MetaMask/metamask-extension#3475 for a more detailed discussionwallet_signMessage
RPC method available to interact with wallets on the browser will call the internalpersonal_sign
method which adds constructs the signature assign(keccak256("\x19Ethereum Signed Message:\n" + len(message) + message)))
. For a more detailed reference, see https://docs.walletconnect.com/advanced/multichain/rpc-reference/ethereum-rpc#personal_signeth_sign
in the advanced settings. This is currently the used approach and the fastest to iterate on the demowallet_signTransaction
method or has theeth_sign
method still available. This leads to due possible paths for the web-demo: