Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/ethabi mainline #1266

Closed
wants to merge 4 commits into from
Closed

Chore/ethabi mainline #1266

wants to merge 4 commits into from

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Feb 3, 2022

This has been compiled against a version of ethabi that is almost identical to the rust-ethereum master branch.

I forked ethabi to my personal github so as not to conflict with the existing ethabi fork we have in the chainflip org. Ideally I'll get the change pushed upstream to rust-ethereum and then we can use something more official.

Closes #1237

@dandanlen dandanlen requested a review from morelazers February 3, 2022 14:31
Copy link

@morelazers morelazers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, do we want to lock to a commit on your personal repo such that we're not vulnerable to supply chain attacks? 😛

@dandanlen
Copy link
Collaborator Author

It might be merged into the main ethabi repo. rust-ethereum/ethabi#260

@dandanlen
Copy link
Collaborator Author

Closing this, superseded by #1650

@dandanlen dandanlen closed this May 20, 2022
@ahasna ahasna deleted the chore/ethabi-mainline branch May 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SC-1946] Move back to ethabi master
2 participants