Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved how stale data is purged in the witnesser pallet #2117

Merged
merged 8 commits into from
Sep 7, 2022
Merged

feat: improved how stale data is purged in the witnesser pallet #2117

merged 8 commits into from
Sep 7, 2022

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Sep 5, 2022 •
edited by gitpod-io bot
Loading

Stale data is now purged in on_idle hook.
Data is purged based on weights available

Closes #2103

@syan095 syan095 marked this pull request as ready for review September 6, 2022 04:15
@syan095 syan095 requested review from dandanlen and kylezs and removed request for dandanlen September 6, 2022 04:15
dandanlen
dandanlen reviewed Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, but LGTM overall.

state-chain/pallets/cf-witnesser/src/lib.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/benchmarking.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/tests.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/tests.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/benchmarking.rs Outdated Show resolved Hide resolved
kylezs
kylezs reviewed Sep 6, 2022
View reviewed changes
state-chain/pallets/cf-witnesser/src/tests.rs Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/tests.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/lib.rs Outdated Show resolved Hide resolved
state-chain/pallets/cf-witnesser/src/lib.rs Outdated Show resolved Hide resolved
@syan095
Addressed some PR comments
d976179
@syan095
Merge branch 'develop' into fix/purge-witnesser-data
246cb55 
* develop:
  Chore/refactor remove witness (#2127)
  Refactor: Changed participants from`Vec` to `BTreeSet` (#2116)
  chore: initial practices readme (#2086)
@syan095
Adjusted how the weights are calculated when deleting itmes
503cd7e 
Re-benchmarked
@syan095 syan095 requested review from dandanlen and kylezs September 7, 2022 06:18
kylezs
kylezs reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@kylezs kylezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will let Dan give final approve.

dandanlen
dandanlen approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dandanlen dandanlen changed the title Improved how stale data is purged in the witnesser pallet feat: improved how stale data is purged in the witnesser pallet Sep 7, 2022
@dandanlen dandanlen merged commit 7bec2eb into develop Sep 7, 2022
@dandanlen dandanlen deleted the fix/purge-witnesser-data branch September 7, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylezs kylezs kylezs left review comments

@dandanlen dandanlen dandanlen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent block bloat when purging witness data
3 participants
@syan095 @dandanlen @kylezs