Divide logic between enum variants #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MxmUrw
reviewed
Dec 11, 2024
Comment on lines
+182
to
+192
| ChainProgress::Reorg(reorg_range) => { | ||
| // Delete any elections that are ongoing for any blocks in the reorg range. | ||
| for (i, election_identifier) in election_identifiers.into_iter().enumerate() { | ||
| let election = ElectoralAccess::election_mut(election_identifier); | ||
| let properties = election.properties()?; | ||
| if properties.0.into_range_inclusive() == *reorg_range { | ||
| election.delete(); | ||
| open_elections = open_elections.saturating_sub(1); | ||
| remaining_election_identifiers.remove(i); | ||
| } | ||
| } |
There was a problem hiding this comment.
Actually, when I detect a reorg, I have two ranges: removed and added. Depending on circumstances either one could be "longer" then the other. removed are the headers which I have previously witnessed and forwarded to you and are now invalid due to the reorg, added are the replacement headers now valid after the reorg.
It seems to me that since you want to delete the previously created elections, and recreate elections for the new blocks, you actually want to get both ranges. So I propose to change the variant to be ChainProgress::Reorg { removed_range: InclusiveRange<>, added_range: InclusiveRange<> }
MxmUrw
reviewed
Dec 11, 2024
state-chain/pallets/cf-elections/src/electoral_systems/block_witnesser.rs
Show resolved
Hide resolved
kylezs
added a commit
that referenced
this pull request
Dec 17, 2024
* wip * divide logic between enum variants
MxmUrw
pushed a commit
that referenced
this pull request
Jan 27, 2025
* wip * divide logic between enum variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.