feat: VoterApi::vote now returns an Option.
#5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor/PRO-1980/consolidate-electoralsystem-and-runner-traits
to
main
January 27, 2025 13:20
MxmUrw
force-pushed
the
feat/PRO-1979/make-return-value-of-voterapi-optional
branch
from
3a8402d to
3dda26b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5589 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 511 511
Lines 90565 90479 -86
Branches 90565 90479 -86
======================================
- Hits 64429 64317 -112
- Misses 23595 23619 +24
- Partials 2541 2543 +2 ☔ View full report in Codecov by Sentry. |
The voter api can now signal that it doesn't have anything to vote for by returning `Ok(None)`. Previously, in such cases we had to return `Err(..)`, which lead to the RetrierClient scheduling an exponential backoff.
MxmUrw
force-pushed
the
feat/PRO-1979/make-return-value-of-voterapi-optional
branch
from
3dda26b to
afd2e97
Compare
dandanlen
reviewed
Feb 4, 2025
engine/src/elections.rs
Outdated
| @@ -176,6 +176,9 @@ where | |||
|
|
|||
| pending_submissions.insert(election_identifier, (partial_vote, vote)); | |||
| }, | |||
| Ok(None) => { | |||
| info!("Voting task for election '{:?}' returned 'None' (nothing to submit).", election_identifier); | |||
There was a problem hiding this comment.
nit: I feel like debug would be more appropriate here otherwise we'll see a lot of spam.
There was a problem hiding this comment.
Suggested change
| info!("Voting task for election '{:?}' returned 'None' (nothing to submit).", election_identifier); | |
| debug!("Voting task for election '{:?}' returned 'None' (nothing to submit).", election_identifier); |
kylezs
approved these changes
Feb 4, 2025
MxmUrw
deleted the
feat/PRO-1979/make-return-value-of-voterapi-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1979
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The voter api can now signal that it doesn't have anything to vote for by returning
Ok(None). Previously, in such cases we had to returnErr(..), which lead to the RetrierClient scheduling an exponential backoff.