Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump try-runtime version to v0.8.0 #5612

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Feb 6, 2025

Pull Request

Closes: PRO-2013

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

I'm about to build some more on top of the try-runtime so this is in preparation:

  1. Bumps the try-runtime version to 0.8.0 (current latest).
  2. Displays the error that the underlying try-runtime returns when erroring, instead of the "check node logs" message.

@kylezs kylezs requested review from nmammeri and dandanlen and removed request for dandanlen and martin-chainflip February 6, 2025 13:04
@nmammeri
Copy link
Contributor

nmammeri commented Feb 6, 2025

One thing I'm not sure about is hardcoding the blocktime to 6000. Apart from that, all looks good to me.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@kylezs
Copy link
Contributor Author

kylezs commented Feb 6, 2025

One thing I'm not sure about is hardcoding the blocktime to 6000. Apart from that, all looks good to me.

Hmm, not sure where we would fetch it from exactly.

Based on the PR it was added in: https://github.com/paritytech/try-runtime-cli/pull/86/files it seems to be related to multi-block migrations (MBMs) - so it seems to just check that the migration can complete within that time, so not super important really (in fact is a little bit annoying we have to provide this as an argument to try-runtime at all tbh).

@kylezs kylezs added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@kylezs kylezs added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@dandanlen
Copy link
Collaborator

dandanlen commented Feb 7, 2025

The upgrade test ran for much longer than usual (not actually sure this is true) and then timed out:

Error: Timed out after 1800s.
    at runWithTimeout (/opt/actions-runner/_work/chainflip-backend/chainflip-backend/bouncer/shared/utils.ts:304:27)
    at runWithTimeoutAndExit (/opt/actions-runner/_work/chainflip-backend/chainflip-backend/bouncer/shared/utils.ts:317:9)
    at <anonymous> (/opt/actions-runner/_work/chainflip-backend/chainflip-backend/bouncer/commands/upgrade_network.ts:125:7)

Could be related to this block time argument?

@kylezs kylezs added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@kylezs kylezs added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@kylezs kylezs force-pushed the chore/bump-try-runtime-cli branch from 7f44ac8 to 6333bb4 Compare February 10, 2025 09:12
@kylezs kylezs enabled auto-merge February 10, 2025 09:12
@kylezs kylezs added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@kylezs kylezs force-pushed the chore/bump-try-runtime-cli branch from 62e4c8c to cb1bc51 Compare February 10, 2025 12:59
@kylezs kylezs added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@kylezs kylezs added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@kylezs kylezs marked this pull request as draft February 11, 2025 15:29
@kylezs kylezs marked this pull request as draft February 11, 2025 15:29
@kylezs kylezs mentioned this pull request Feb 13, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants