-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump try-runtime version to v0.8.0 #5612
base: main
Are you sure you want to change the base?
Conversation
One thing I'm not sure about is hardcoding the blocktime to 6000. Apart from that, all looks good to me. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Hmm, not sure where we would fetch it from exactly. Based on the PR it was added in: https://github.com/paritytech/try-runtime-cli/pull/86/files it seems to be related to multi-block migrations (MBMs) - so it seems to just check that the migration can complete within that time, so not super important really (in fact is a little bit annoying we have to provide this as an argument to |
The upgrade test
Could be related to this block time argument? |
7f44ac8
to
6333bb4
Compare
62e4c8c
to
cb1bc51
Compare
Pull Request
Closes: PRO-2013
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
I'm about to build some more on top of the try-runtime so this is in preparation:
try-runtime
returns when erroring, instead of the "check node logs" message.