Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade subxt to 0.39.0 #5625

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nmammeri
Copy link
Contributor

@nmammeri nmammeri commented Feb 10, 2025

Pull Request

Closes: PRO-2026

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Subxt 0.39.0 introduces breaking changes. subxt is now completely decoupled from subtrate and doesn't require it as dependency (substrate-compat feature is removed)
  • They have introduced basic types instead of substrate types such as: subxt::utils::H256 instead of sp_core::H256.
  • The changes made in this PR mainly address this type conversion issues especially for the dot chain.
  • There were a lot of assumptions that the dot chain hash type is sp_core::H256, this PR changes the dot hash type to be pub type PolkadotHash = <subxt::PolkadotConfig as subxt::Config>::Hash;
  • PR passes full bouncer tests

@nmammeri nmammeri requested review from kylezs and a team as code owners February 10, 2025 16:33
@nmammeri nmammeri requested review from jerryafr, acdibble and dandanlen and removed request for a team, acdibble and jerryafr February 10, 2025 16:33
Copy link

codecov bot commented Feb 10, 2025

@nmammeri nmammeri force-pushed the feature/pro-2026/upgrade-subxt-to-0390 branch from 843ca58 to 4e4eab4 Compare February 11, 2025 10:50
@dandanlen
Copy link
Collaborator

Please don't merge yet - I want to look into this to see if we can avoid importing polkadot-sdk a second time 🙈

@kylezs kylezs marked this pull request as draft February 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants