feat: returning detailed account information for affiliate in the cf_account_info rpc for brokers

[Janislav]

Pull Request

Closes: PRO-2038

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have written sufficient tests.
• I have written and tested required migrations.
• I have updated documentation where appropriate.

Summary

• Return affiliate details + usdc balance of affiliates for a broker account
• Deprecated earned_fees field

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
state-chain/custom-rpc/src/lib.rs	86%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[dandanlen]

I think the idea was to also add account balances for all account types, so that it would also show if the account is an unregistered affiliate.

Something like this:

pub struct RpcAccountInfoWithBalances {
	asset_balances: any::AssetMap<NumberOrHex>,
	#[serde(flatten)]
	account_info: RpcAccountInfo,
}

And then change the rpc return type to RpcAccountInfoWithBalances.

[dandanlen]

Might as well deprecate this too and add the account_id into RpcAffiliateDetails.

[dandanlen]

Suggested change

	pub earned_fees: NumberOrHex,
	pub balance: NumberOrHex,

Feedback was that earned_fees was misleading because it didn't include 'all time' fees.

[Janislav]

I think balance is misleading since it is not the on chain balance but the collected fees in usdc

[dandanlen]

Unfortunately this is a breaking change to the runtime API. We can do this but we should manage it using runtime api versioning (see the doc comment on the CustomRuntimeApi trait).

Alternatively maybe we can get the data we need via get_affiliates.