Fix config archs support
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you try and specify the `archs` option in the config file, the publish command fails along the lines of ``` line 7: cannot unmarshal !!int `386` into types.Architecture line 7: cannot unmarshal !!str `amd64` into types.Architecture ``` Add a custom `UnmarshalYAML` function to `Architecture`, supporting decoding the string values into the correct `Architecture` object.
Currently if we specify 1 arch under `bc.ImageConfiguration.Archs`, the publish command will handle it, however if we have more than 1 the default case uses `archs`, which is defaulted to all entries (cli options). Swap out the default range case to use `bc.ImageConfiguration.Archs`, which will be set to `archs` in the default case (no config specified).
DamianZaremba
force-pushed
the
fix-config-archs-support
branch
from
72e2625 to
ffba058
Compare
This will ensure mink exercises all 3 cases of archs handling in the cli commands.
dlorenc
reviewed
Apr 3, 2022
|
I think that |
I think everything is good now after chainguard-dev/actions#36, unless I'm missing something. |
|
Yeah seems so. |
kaniini
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be 2 issues with the current
archssupport from the config file.Currently if you try and specify the
archsoption in the config file,the publish command fails along the lines of
Add a custom
UnmarshalYAMLfunction toArchitecture, supportingdecoding the string values into the correct
Architectureobject.Currently if we specify 1 arch under
bc.ImageConfiguration.Archs, thepublish command will handle it, however if we have more than 1 the
default case uses
archs, which is defaulted to all entries (clioptions).
Swap out the default range case to use
bc.ImageConfiguration.Archs,which will be set to
archsin the default case (no config specified).