Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a flag option #10

Merged
merged 4 commits into from
Feb 6, 2024
Merged

add a flag option #10

merged 4 commits into from
Feb 6, 2024

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Feb 2, 2024

I don't like any of the names here, and we might want it to be in a separate subpackage. This lets you say --log-level=DEBUG to set the level. The default is still INFO.

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh requested a review from wlynch February 2, 2024 21:45
Signed-off-by: Jason Hall <jason@chainguard.dev>
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! +1 on using a separate package to make it opt in.

slag/flag.go Show resolved Hide resolved
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh marked this pull request as ready for review February 6, 2024 00:57
@imjasonh imjasonh changed the title WIP: add a flag option add a flag option Feb 6, 2024
@imjasonh imjasonh enabled auto-merge (squash) February 6, 2024 03:07
@imjasonh imjasonh merged commit 83244dc into chainguard-dev:main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants