fix newest-file selection for offline cache

chainguard-dev · Mar 1, 2024 · 41d030c · 41d030c
1 parent 7ea5a30
commit 41d030c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/apk/cache.go b/pkg/apk/cache.go
@@ -206,11 +206,15 @@ func (t *cacheTransport) RoundTrip(request *http.Request) (*http.Response, error
 				return nil, err
 			}
 
-			if fi.ModTime().After(newest.ModTime()) {
+			if (fi.ModTime().After(newest.ModTime()) || newest.IsDir()) && !fi.IsDir() {
 				newest = fi
 			}
 		}
 
+		if newest.IsDir() {
+			return nil, fmt.Errorf("%s is a directory", newest.Name())
+		}
+
 		f, err := os.Open(filepath.Join(cacheDir, newest.Name()))
 		if err != nil {
 			return nil, err