Propagate user from image configuration #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormqueen1990
previously approved these changes
Mar 19, 2024
imjasonh
previously approved these changes
Mar 19, 2024
This works for both build and test, but will probably be harder to make work with builds because of file ownership shenanigans. For tests, this makes it possible to test non-root users for packages that get mad if you run them as root. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
jonjohnsonjr
dismissed stale reviews from imjasonh and stormqueen1990
via
30e42b6
stormqueen1990
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works for both build and test, but will probably be harder to make work with builds because of file ownership shenanigans. For tests, this makes it possible to test non-root users for packages that get mad if you run them as root.