skip mounting resolv.conf for the docker runner #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
skip-resolv-docker
branch
from
f03ce30 to
5d16869
Compare
imjasonh
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've been improperly mounting in the hosts
/etc/resolv.confforever, and have gotten away with it because some systems (docker desktop) works okay because thenameserverstill resolves, but does not on others.this ignores
/etc/resolv.conffor the docker runner so we just fallback to letting docker manage its own/etc/resolv.confthis should fix the
could not resolve host: ...errors we've been seeing in GHA everytime we try to migrate to--runner docker