ensure shbang check only checks valid shbangs #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
shbang-fix
branch
3 times, most recently
from
6fd96bb to
3fc460d
Compare
xnox
reviewed
Apr 23, 2024
Signed-off-by: Josh Wolf <josh@wolfs.io>
xnox
approved these changes
Apr 23, 2024
|
@joshrwolf note to actually fix this; there needs to be a release cut; and wolfictl release cut; and images updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous implementation was matching on invalid shbangs (
##) due to the conditional&&it was also erroneously checking and logging errors on directories