Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cargo): Install all built binaries if output isn't defined #1174

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix(cargo): Install all built binaries if output isn't defined #1174

merged 1 commit into from
Apr 28, 2024

Conversation

EyeCantCU
Copy link
Member

@EyeCantCU EyeCantCU commented Apr 28, 2024 •
edited
Loading

Support installing multiple rust binaries after building them with cargo

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@EyeCantCU
fix(cargo): Install all built binaries if output isn't defined
aff7cb2 
Support installing multiple rust binaries after building them with cargo

Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
@imjasonh imjasonh merged commit 054e788 into main Apr 28, 2024
35 checks passed
@imjasonh imjasonh deleted the cargo-mult-bins branch April 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyeCantCU @imjasonh